Extend keybinds with navigation#67
Merged
MartinBozhilov-coh merged 3 commits intonavigation-componentfrom Feb 6, 2026
Merged
Conversation
MihailTodorov
approved these changes
Feb 5, 2026
Comment on lines
222
to
225
| '0': Icon.gamepad.ps5.cross, | ||
| '1': Icon.gamepad.ps5.circle, | ||
| '2': <Icon.gamepad.ps5.square style={{width: '5vmax', height: '5vmax'}} />, | ||
| '3': <img src={customGlyphIcon} />, |
Contributor
There was a problem hiding this comment.
Add comments with // to showcase the different ways to use the Icon
There was a problem hiding this comment.
Pull request overview
This pull request extends the Keybinds component with gamepad support and integrates it with the Navigation component system. The changes enable developers to bind gamepad buttons in addition to keyboard/mouse inputs, with proper visual glyph representation.
Changes:
- Added gamepad mode support to Keybinds/Keybind components with configurable glyph overrides
- Implemented pauseInput/resumeInput methods in Navigation for global action input control
- Updated import paths for interaction-manager types to use a unified entry point
- Added comprehensive tests and documentation for gamepad functionality
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/src/components/Keybinds/KeybindsTest.tsx | Added test scenarios for gamepad mode with Navigation integration and custom glyph overrides |
| tests/specs/keybinds.spec.js | Added test suite for gamepad mode including glyph rendering, rebinding, and action pause behavior |
| tests/shared/keybinds/keybinds-selectors.json | Added selector for action test element |
| tests/shared/keybinds/glyph-mappings.json | New file with gamepad button mappings for test data |
| src/components/Utility/Navigation/types.ts | Consolidated imports from interaction-manager into single entry point |
| src/components/Utility/Navigation/areaMethods/useAreaMethods.ts | Updated import path for KeyName type |
| src/components/Utility/Navigation/areaMethods/areaMethods.types.ts | Updated import path for KeyName type |
| src/components/Utility/Navigation/actionMethods/useActionMethods.ts | Implemented pauseInput/resumeInput methods with snapshot logic for paused action states |
| src/components/Utility/Navigation/actionMethods/actionMethods.types.ts | Added JSDoc documentation for pauseInput/resumeInput methods |
| src/components/Media/Icon/Icon.tsx | Added optional chaining for props.class to prevent potential undefined errors |
| src/components/Basic/Keybinds/util/glyphs.ts | New file defining default gamepad button-to-glyph mappings using Xbox layout |
| src/components/Basic/Keybinds/Keybinds.tsx | Added gamepad mode support, button input sanitization, and glyph override functionality |
| src/components/Basic/Keybinds/Keybinds.module.scss | Extended hover styles to include focus state for keyboard/gamepad navigation |
| src/components/Basic/Keybinds/Keybind.tsx | Implemented gamepad listening logic with button polling and axis detection |
| package.json | Updated coherent-gameface-interaction-manager from 2.6.0 to 2.8.0 |
| docs/src/content/docs/components/Utility/Navigation.mdx | Documented new pauseInput/resumeInput API methods |
| docs/src/content/docs/components/Basic/keybinds.mdx | Added comprehensive gamepad support documentation with usage examples |
| docs/src/content/docs/changelog/index.mdx | Added changelog entry for Keybind navigation actions and gamepad guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alien1976
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.